[Kde-pim] Review Request: Fix the message selection and viewing after a quick search filter has been applied (Bug 130247)

[George Metaxas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6126/
-----------------------------------------------------------

Review request for KDE PIM.


Summary
-------

The quick search bar filters the message list according to its contents. When the user selects a message from this list, it appears at the bottom, in the message preview pane. If the user presses the Enter key, while the message list has focus, the selected message is opened in a new window. However, one would expect that if a quick search filter is applied, leading to the selected message not being shown in the list anymore, the message preview pane will not display the message and upon pressing Enter on the message list, the message will not be opened in a new window (as it is not visible in the message list anymore). This patch fixes this behaviour, by clearing the message preview pane from the current message and the message list of the current selection, if a message is filtered out of sight. The behaviour implemented, will allows KMail to remember and show the message last selected, as long as it is displayed on the message list. 


This addresses bug 130247.
    https://bugs.kde.org/show_bug.cgi?id=130247


Diffs
-----

  /trunk/KDE/kdepim/kmail/kmmainwidget.h 1206962 
  /trunk/KDE/kdepim/kmail/kmmainwidget.cpp 1206962 
  /trunk/KDE/kdepim/messagelist/core/view.h 1206962 
  /trunk/KDE/kdepim/messagelist/core/view.cpp 1206962 
  /trunk/KDE/kdepim/messagelist/core/widgetbase.h 1206962 
  /trunk/KDE/kdepim/messagelist/core/widgetbase.cpp 1206962 
  /trunk/KDE/kdepim/messagelist/pane.h 1206962 
  /trunk/KDE/kdepim/messagelist/pane.cpp 1206962 

Diff: http://svn.reviewboard.kde.org/r/6126/diff


Testing
-------

Tested the following conditions:
- No messages selected, set/unset filter
- Selecting a message, setting a filter that won't cause the selected message to be hidden, unsetting the filter.
- Selecting a message, setting a filter that will cause the selected message to be hidden, unsetting the filter.


Thanks,

George

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/