[Kde-pim] Re: Review Request: Convert the remainder of KMail configuration to KConfigXT (Bug 89446)

[Till Adam]

On Friday 31 December 2010 08:43:58 George Metaxas wrote:
> > On 2010-12-30 12:45:18, Till Adam wrote:
> > > kmail/kmcomposereditor.cpp, line 79
> > > <http://git.reviewboard.kde.org/r/100266/diff/1/?file=5821#file5821l
> > > ine79>
> > > 
> > >     I guess theses can simply be initialized to empty, given
> > >     that the quotedTextN() now return the right default?
> 
> What about the case where useDefaultColours is true? Unless I remove the if
> statement and simply initialise them to the values of quotedTextN().

Hm, no, you're right, the useGlobalColors seems to be an override. Still, 
probably better to retrieve the default from the KConfigXT item, instead of 
duplicating it here in the code.

Till
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/