[Kde-pim] Re: Review Request: kmail: fix 251009 bug. Send mail doesn't stored in the default send-mail folder if the custom one doesn't exist

[Till Adam]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100269/#review677
-----------------------------------------------------------


Thanks for the patch, but I'm afraid your solution doesn't quite work. You're checking whether the collection in the attribute is valid three lines before it is being set :). I don't think that can work.

- Till


On 2010-12-30 17:07:03, Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100269/
> -----------------------------------------------------------
> 
> (Updated 2010-12-30 17:07:03)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> Hello
> 
> If you tried to send an email but the custom send-mail folder (settings->configure kmail->identities->modify->advanced) doesn't exist then the kmail doesn't store the send-mail into the default... So with this patch the send-mail is saved in the custom folder (if it exists) otherwise it is saved in the default one...
> 
> 
> This addresses bug 251009.
>     http://bugs.kde.org/show_bug.cgi?id=251009
> 
> 
> Diffs
> -----
> 
>   messagecomposer/composerviewbase.cpp 84b6fe8 
> 
> Diff: http://git.reviewboard.kde.org/r/100269/diff
> 
> 
> Testing
> -------
> 
> The kmail compiles fine and kmail works without any issue
> 
> 
> Thanks,
> 
> Antonis
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/