[Kde-pim] Re: Review Request: Convert the remainder of KMail configuration to KConfigXT (Bug 89446)

[George Metaxas]

> On 2010-12-30 12:45:18, Till Adam wrote:
> > kmail/kmcomposereditor.cpp, line 79
> > <http://git.reviewboard.kde.org/r/100266/diff/1/?file=5821#file5821line79>
> >
> >     I guess theses can simply be initialized to empty, given that the quotedTextN() now return the right default?

What about the case where useDefaultColours is true? Unless I remove the if statement and simply initialise them to the values of quotedTextN().


- George


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100266/#review667
-----------------------------------------------------------


On 2010-12-29 20:40:28, George Metaxas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100266/
> -----------------------------------------------------------
> 
> (Updated 2010-12-29 20:40:28)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> The current version of KMail has some parts of its configuration not being accessed through the KConfigXT mechanism, as that is implemented through the various GlobalSettings classes. This patch ports the largest remaining part of the code, to use the GlobalSettings class (and related classes in other namespaces). Some parts of the code have not been ported, such as the handling of configuration with multiple  items of the same type (Akonadi resources, Folders, antispam tool configuration), and some parts of the code that do not really belong to the KMail configuration (the migration process (kmmail-migratorrc), pid and lock stuff). This patch mainly looks at the code in the kmail folder. Some of the configuration entries were moved to a .kcfg file in a different subfolder (such as messagecore or messageviewer).
> 
> 
> This addresses bug 89446.
>     http://bugs.kde.org/show_bug.cgi?id=89446
> 
> 
> Diffs
> -----
> 
>   kmail/configuredialog.cpp d02cbad 
>   kmail/globalsettings_base.kcfgc f9a0ea4 
>   kmail/identitydialog.cpp 96549d2 
>   kmail/kmail.kcfg.cmake fadb2c1 
>   kmail/kmcommands.cpp 2dfbec5 
>   kmail/kmcomposereditor.cpp bdee9fb 
>   kmail/kmcomposewin.cpp 76595b5 
>   kmail/kmfilterdlg.cpp 92d13e4 
>   kmail/kmkernel.cpp 61e87a6 
>   kmail/kmmainwidget.cpp 0f356d3 
>   kmail/kmstartup.cpp ef54d75 
>   kmail/searchwindow.cpp 4b5ccdc 
>   messagecomposer/messagecomposer.kcfg.cmake 203668a3 
>   messagecore/messagecore.kcfg f1a5425 
>   messageviewer/messageviewer.kcfg.cmake 3ae0f43 
> 
> Diff: http://git.reviewboard.kde.org/r/100266/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> George
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/