[Kde-pim] Re: Review Request: Show event indicators over agenda

[Aurélien Gâteau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6036/
-----------------------------------------------------------

(Updated 2010-12-03 19:40:17.485966)


Review request for KDE PIM.


Changes
-------

It remains usable as long as the column is 12 pixels wide or more. If columns get thinner the arrow looks like it is on the column on the left. It still indicates something is hidden so I think it's still somehow useful.


Summary
-------

The agenda view can show arrows for events which are outside the currently visible part of the agenda. These event indicators are in their own bar and takes away valuable vertical space. Attached patch turns them into lighter arrows (using arrow characters instead of pixmaps) and display them over the agenda, giving more space for the agenda view itself.


Diffs
-----

  trunk/KDE/kdepim/calendarviews/eventviews/agenda/agendaview.h 1203297 
  trunk/KDE/kdepim/calendarviews/eventviews/agenda/agendaview.cpp 1203297 

Diff: http://svn.reviewboard.kde.org/r/6036/diff


Testing
-------


Screenshots
-----------

Before 1
  http://svn.reviewboard.kde.org/r/6036/s/571/
Before 2
  http://svn.reviewboard.kde.org/r/6036/s/572/
After 1
  http://svn.reviewboard.kde.org/r/6036/s/573/
After 2
  http://svn.reviewboard.kde.org/r/6036/s/574/
After, packed
  http://svn.reviewboard.kde.org/r/6036/s/575/


Thanks,

Aurélien

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/