[Kde-pim] Re: Review Request: Removing "local folder" entry from file menu in kmail2

Till Adam adam at kde.org
Thu Dec 30 12:56:10 GMT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100249/#review668
-----------------------------------------------------------


The functionality behind this is actually useful, as it discovers any new mail that might have been delivered into the local folders externally. "Check mail" is bad wording for this, indeed, but I do believe the option should be available, since it serves a useful purpose.

- Till


On 2010-12-26 20:32:47, Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100249/
> -----------------------------------------------------------
> 
> (Updated 2010-12-26 20:32:47)
> 
> 
> Review request for KDEPIM.
> 
> 
> Summary
> -------
> 
> Hello
> 
> This patch is fixing the "- Check Mail In: Has useless submenu entry "Local Folders" ", please take a look in my reply in the 223818 bug report... I have remove that entry because it doesn't make any sense...
> 
> 
> P.S. This is not a new patch but it is moved from the http://svn.reviewboard.kde.org/r/6117/. In the svn.reviewboard.kde there are snapshot from "before" and the "after". I didn't re-upload them because i had remove them from my laptop... Sorry.
> 
> 
> This addresses bug 223818.
>     http://bugs.kde.org/show_bug.cgi?id=223818
> 
> 
> Diffs
> -----
> 
>   kmail/kmmainwidget.cpp 0f356d3 
> 
> Diff: http://git.reviewboard.kde.org/r/100249/diff
> 
> 
> Testing
> -------
> 
> The patch is working and the kmail compiles without any problem.
> 
> 
> Thanks,
> 
> Antonis
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list