[Kde-pim] Re: Review Request: Fix vcal export with TZ

Allen Winter winter at kde.org
Sat Dec 4 14:10:46 GMT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6043/#review9124
-----------------------------------------------------------

Ship it!


Please commit ASAP.
Also, in your commit message please mention that there is a small API change and put the line
CCMAIL: kde-bindings at kde.org

- Allen


On 2010-12-04 13:50:03, Alvaro Manera wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6043/
> -----------------------------------------------------------
> 
> (Updated 2010-12-04 13:50:03)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Two fixes in one..
> Added TZ exporting functionality to save() method. Before was only in toString().
> Also fixed an infinity loop. On the conversion that Allen did from meego repo to this one, he added the const to the parseDst(), but it is by reference, because it is modified. Reverted those changes...
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepimlibs/kcalcore/vcalformat.h 1203479 
>   trunk/KDE/kdepimlibs/kcalcore/vcalformat.cpp 1203479 
> 
> Diff: http://svn.reviewboard.kde.org/r/6043/diff
> 
> 
> Testing
> -------
> 
> in meego it works :)
> 
> 
> Thanks,
> 
> Alvaro
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list