[Kde-pim] Review Request: Don't make structural nodes appear in mobile apps

Stephen Kelly steveire at gmail.com
Thu Dec 23 18:38:13 GMT 2010


Hi,

Reviewboard doesn't like me, so we'll have to do this one the
old-fashioned way. Also, this is the second time I write this email.
KNode just crashed and ate the version of this that I wrote and tried
to send. The previous version was far better and more epic, but is now
lost in the ether. I have learned my lesson and am drafting this in
kate instead.

I've attached a patch which makes structural collections not appear in
the mobile apps. It is similar to how kmail desktop resolves this
issue. I don't like the patch for several reasons, one of which is
that because it is recursive, it needs to vist each node, and it
causes all intermediate proxies to have to create and maintain
mappings for every relevant node in the tree. Those mappings all have
to be cleared and recreated each time you navigate up or down, so I
can see this becoming a performance problem.

Tobias, do you have more information on what the problem is so we can
investigate other avenues? I'm sure we visited this issue about a year
ago and then came up with the use of the proxy in kmail desktop, but I
don't remember why we thought that was the best solution, and even if
it is, I think it's not as good in the mobile case.

All the best,

Steve.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: no_groupware.patch
Type: text/x-patch
Size: 4951 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20101223/1197edeb/attachment.bin>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list