[Kde-pim] Re: Review Request: Remove namespace clashes between 4.4. pim and 4.6 pimlibs

[Ingo Klöcker]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6174/#review9345
-----------------------------------------------------------


AFAICS the patch looks sane. I suppose the other stuff in akonadi_next that's also living in the Akonadi namespace (e.g. AmazingCompleter) isn't used anywhere. Or why did you leave this as-is?

This (necessary) change clearly shows that it's a very bad idea to pollute the Akonadi namespace with unfinished stuff. IMO it should be forbidden to use the Akonadi namespace for anything that's not public API (or private stuff that will never ever be made public). In any case the Akonadi namespace should be restricted to kdepimlibs. Just a suggestion to avoid similar symbol clashes in the future.

- Ingo


On 2010-12-20 20:56:07, Will Stephenson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6174/
> -----------------------------------------------------------
> 
> (Updated 2010-12-20 20:56:07)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Move all classes declared in namespace Akonadi in kdepim 4.4 to namespace AkonadiFuture, so that this module continues to work using newer kdepimlibs that include the stable future versions of the experimental classes.
> 
> 
> Diffs
> -----
> 
>   branches/KDE/4.4/kdepim/akonadi/akonadi_next/collectionutils_p.h 1207359 
>   branches/KDE/4.4/kdepim/akonadi/akonadi_next/quotacolorproxymodel.h 1207359 
>   branches/KDE/4.4/kdepim/akonadi/akonadi_next/quotacolorproxymodel.cpp 1207359 
>   branches/KDE/4.4/kdepim/akonadi/kcal/itembrowser.h 1207359 
>   branches/KDE/4.4/kdepim/akonadi/kcal/itembrowser.cpp 1207359 
>   branches/KDE/4.4/kdepim/akonadi/kcal/kcalitembrowser.h 1207359 
>   branches/KDE/4.4/kdepim/akonadi/kcal/kcalitembrowser.cpp 1207359 
>   branches/KDE/4.4/kdepim/akonadiconsole/browserwidget.cpp 1207359 
>   branches/KDE/4.4/kdepim/akonadiconsole/browserwidget_contentview.ui 1207359 
>   branches/KDE/4.4/kdepim/kaddressbook/contactselectionwidget.cpp 1207359 
>   branches/KDE/4.4/kdepim/kaddressbook/globalcontactmodel.h 1207359 
>   branches/KDE/4.4/kdepim/kaddressbook/globalcontactmodel.cpp 1207359 
>   branches/KDE/4.4/kdepim/kaddressbook/mainwidget.h 1207359 
>   branches/KDE/4.4/kdepim/kaddressbook/mainwidget.cpp 1207359 
>   branches/KDE/4.4/kdepim/kaddressbook/modelcolumnmanager.h 1207359 
>   branches/KDE/4.4/kdepim/kaddressbook/modelcolumnmanager.cpp 1207359 
>   branches/KDE/4.4/kdepim/kaddressbook/recursiveitemfetchjob.h 1207359 
>   branches/KDE/4.4/kdepim/kaddressbook/recursiveitemfetchjob.cpp 1207359 
>   branches/KDE/4.4/kdepim/kaddressbook/standardcontactactionmanager.h 1207359 
>   branches/KDE/4.4/kdepim/kaddressbook/standardcontactactionmanager.cpp 1207359 
>   branches/KDE/4.4/kdepim/kalarm/birthdaydlg.cpp 1207359 
>   branches/KDE/4.4/kdepim/kalarm/birthdaymodel.h 1207359 
>   branches/KDE/4.4/kdepim/kalarm/birthdaymodel.cpp 1207359 
>   branches/KDE/4.4/kdepim/libkdepim/contactsfilterproxymodel.h 1207359 
>   branches/KDE/4.4/kdepim/libkdepim/contactsfilterproxymodel.cpp 1207359 
>   branches/KDE/4.4/kdepim/libkdepim/contactstreemodel.h 1207359 
>   branches/KDE/4.4/kdepim/libkdepim/contactstreemodel.cpp 1207359 
>   branches/KDE/4.4/kdepim/nepomuk_email_feeder/nepomukemailfeeder.h 1207359 
>   branches/KDE/4.4/kdepim/nepomuk_email_feeder/nepomukemailfeeder.cpp 1207359 
>   branches/KDE/4.4/kdepim/runtime/agents/nepomuk_calendar_feeder/nepomukcalendarfeeder.h 1207359 
>   branches/KDE/4.4/kdepim/runtime/agents/nepomuk_calendar_feeder/nepomukcalendarfeeder.cpp 1207359 
>   branches/KDE/4.4/kdepim/runtime/agents/nepomuk_contact_feeder/nepomukcontactfeeder.h 1207359 
>   branches/KDE/4.4/kdepim/runtime/agents/nepomuk_contact_feeder/nepomukcontactfeeder.cpp 1207359 
>   branches/KDE/4.4/kdepim/runtime/kresources/shared/resourceconfigbase.h 1207359 
>   branches/KDE/4.4/kdepim/runtime/kresources/shared/resourceconfigbase.cpp 1207359 
>   branches/KDE/4.4/kdepim/runtime/kresources/shared/storecollectiondialog.h 1207359 
>   branches/KDE/4.4/kdepim/runtime/kresources/shared/storecollectiondialog.cpp 1207359 
>   branches/KDE/4.4/kdepim/runtime/kresources/shared/storecollectionfilterproxymodel.h 1207359 
>   branches/KDE/4.4/kdepim/runtime/kresources/shared/storecollectionfilterproxymodel.cpp 1207359 
>   branches/KDE/4.4/kdepim/runtime/kresources/shared/storecollectionmodel.h 1207359 
>   branches/KDE/4.4/kdepim/runtime/kresources/shared/storecollectionmodel.cpp 1207359 
>   branches/KDE/4.4/kdepim/runtime/plugins/akonadi_serializer_addressee.h 1207359 
>   branches/KDE/4.4/kdepim/runtime/plugins/akonadi_serializer_addressee.cpp 1207359 
>   branches/KDE/4.4/kdepim/runtime/plugins/akonadi_serializer_bookmark.h 1207359 
>   branches/KDE/4.4/kdepim/runtime/plugins/akonadi_serializer_bookmark.cpp 1207359 
>   branches/KDE/4.4/kdepim/runtime/plugins/akonadi_serializer_contactgroup.h 1207359 
>   branches/KDE/4.4/kdepim/runtime/plugins/akonadi_serializer_contactgroup.cpp 1207359 
>   branches/KDE/4.4/kdepim/runtime/plugins/akonadi_serializer_kcal.h 1207359 
>   branches/KDE/4.4/kdepim/runtime/plugins/akonadi_serializer_kcal.cpp 1207359 
>   branches/KDE/4.4/kdepim/runtime/plugins/akonadi_serializer_mail.h 1207359 
>   branches/KDE/4.4/kdepim/runtime/plugins/akonadi_serializer_mail.cpp 1207359 
>   branches/KDE/4.4/kdepim/runtime/plugins/akonadi_serializer_microblog.h 1207359 
>   branches/KDE/4.4/kdepim/runtime/plugins/akonadi_serializer_microblog.cpp 1207359 
>   branches/KDE/4.4/kdepim/runtime/resources/contacts/contactsresource.cpp 1207359 
>   branches/KDE/4.4/kdepim/runtime/resources/contacts/settingsdialog.h 1207359 
>   branches/KDE/4.4/kdepim/runtime/resources/contacts/settingsdialog.cpp 1207359 
>   branches/KDE/4.4/kdepim/runtime/resources/ical/icalresourcebase.cpp 1207359 
>   branches/KDE/4.4/kdepim/runtime/resources/imap/imapresource.cpp 1207359 
>   branches/KDE/4.4/kdepim/runtime/resources/knut/knutresource.h 1207359 
>   branches/KDE/4.4/kdepim/runtime/resources/knut/knutresource.cpp 1207359 
>   branches/KDE/4.4/kdepim/runtime/resources/kolabproxy/kolabproxyresource.cpp 1207359 
>   branches/KDE/4.4/kdepim/runtime/resources/mbox/mboxresource.cpp 1207359 
>   branches/KDE/4.4/kdepim/runtime/resources/shared/collectionannotationsattribute.h 1207359 
>   branches/KDE/4.4/kdepim/runtime/resources/shared/collectionannotationsattribute.cpp 1207359 
>   branches/KDE/4.4/kdepim/runtime/resources/shared/collectionflagsattribute.h 1207359 
>   branches/KDE/4.4/kdepim/runtime/resources/shared/collectionflagsattribute.cpp 1207359 
>   branches/KDE/4.4/kdepim/runtime/resources/shared/imapaclattribute.h 1207359 
>   branches/KDE/4.4/kdepim/runtime/resources/shared/imapaclattribute.cpp 1207359 
>   branches/KDE/4.4/kdepim/runtime/resources/shared/imapquotaattribute.h 1207359 
>   branches/KDE/4.4/kdepim/runtime/resources/shared/imapquotaattribute.cpp 1207359 
>   branches/KDE/4.4/kdepim/runtime/resources/shared/singlefileresourceconfigdialog.h 1207359 
>   branches/KDE/4.4/kdepim/runtime/resources/shared/singlefileresourceconfigdialogbase.h 1207359 
>   branches/KDE/4.4/kdepim/runtime/resources/shared/singlefileresourceconfigdialogbase.cpp 1207359 
>   branches/KDE/4.4/kdepim/runtime/resources/vcard/vcardresource.cpp 1207359 
>   branches/KDE/4.4/kdepim/runtime/resourcetester/xmloperations.h 1207359 
>   branches/KDE/4.4/kdepim/runtime/resourcetester/xmloperations.cpp 1207359 
>   branches/KDE/4.4/kdepim/runtime/xml/akonadi2xml.cpp 1207359 
>   branches/KDE/4.4/kdepim/runtime/xml/format_p.h 1207359 
>   branches/KDE/4.4/kdepim/runtime/xml/tests/collection.cpp 1207359 
>   branches/KDE/4.4/kdepim/runtime/xml/tests/xmldocumenttest.cpp 1207359 
>   branches/KDE/4.4/kdepim/runtime/xml/xmldocument.h 1207359 
>   branches/KDE/4.4/kdepim/runtime/xml/xmldocument.cpp 1207359 
>   branches/KDE/4.4/kdepim/runtime/xml/xmlreader.h 1207359 
>   branches/KDE/4.4/kdepim/runtime/xml/xmlreader.cpp 1207359 
>   branches/KDE/4.4/kdepim/runtime/xml/xmlwritejob.h 1207359 
>   branches/KDE/4.4/kdepim/runtime/xml/xmlwritejob.cpp 1207359 
>   branches/KDE/4.4/kdepim/runtime/xml/xmlwriter.cpp 1207359 
> 
> Diff: http://svn.reviewboard.kde.org/r/6174/diff
> 
> 
> Testing
> -------
> 
> Build test and basic smoke test of the apps.
> 
> 
> Thanks,
> 
> Will
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/