[Kde-pim] Re: Review Request: Right align time labels
Aurélien Gâteau
agateau at kde.org
Wed Dec 8 22:21:55 GMT 2010
> On 2010-12-08 00:46:52, Allen Winter wrote:
> > pretty
Thanks, applied.
- Aurélien
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6069/#review9170
-----------------------------------------------------------
On 2010-12-07 23:26:36, Aurélien Gâteau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6069/
> -----------------------------------------------------------
>
> (Updated 2010-12-07 23:26:36)
>
>
> Review request for KDE PIM.
>
>
> Summary
> -------
>
> Aligning time labels to the right makes it more clear that they work with the agenda view. I also replaced the hardcoded gray for hours of the day before and after with shades of the window text to ensure we match the user color scheme.
>
>
> Diffs
> -----
>
> trunk/KDE/kdepim/calendarviews/eventviews/agenda/timelabels.h 1204497
> trunk/KDE/kdepim/calendarviews/eventviews/agenda/timelabels.cpp 1204497
>
> Diff: http://svn.reviewboard.kde.org/r/6069/diff
>
>
> Testing
> -------
>
> Tested with one and two time zones.
>
>
> Screenshots
> -----------
>
> Right aligned time labels
> http://svn.reviewboard.kde.org/r/6069/s/576/
>
>
> Thanks,
>
> Aurélien
>
>
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
More information about the kde-pim
mailing list