[Kde-pim] Review Request: Kmail: Do not ask in which Adressbook to add a contact when only one exist and use it instead

[Ingo Klöcker]

> On 2010-08-27 11:58:16, Thomas McGuire wrote:
> > /trunk/KDE/kdepim/libkdepim/addemailaddressjob.cpp, line 23
> > <http://reviewboard.kde.org/r/5166/diff/2/?file=34782#file34782line23>
> >
> >     Qt includes should be after KDE includes.
> >     The include order is:
> >     - own includes
> >     - kdepim includes (like libkdepim)
> >     - kdepimlibs includes
> >     - kdelibs incldues
> >     - qt includes
> >     - system includes (like stdlib)
> >     
> >     I don't remember the reason for the ordering though :)

This ordering enforces the completeness of includes to a certain degree. For details see http://www.topology.org/linux/include.html .


- Ingo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5166/#review7241
-----------------------------------------------------------


On 2010-08-27 10:40:51, Nicolas Lécureuil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5166/
> -----------------------------------------------------------
> 
> (Updated 2010-08-27 10:40:51)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> In KMail when we want to add a contact in the addressbook and if there is only one adressbook, a window will open with only one choice.
> With this patch the only adressbook is choosed directly.
> 
> If there is no adressbook available, an empty list open. With this patch a QMessageBox explain to the user what to do.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/libkdepim/addemailaddressjob.h 1128979 
>   /trunk/KDE/kdepim/libkdepim/addemailaddressjob.cpp 1128979 
> 
> Diff: http://reviewboard.kde.org/r/5166/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nicolas
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/