[Kde-pim] Review Request: KCalCore, updates missing recurrenceId

Alvaro Manera alvaro.manera at nokia.com
Thu Aug 19 12:57:07 BST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5070/
-----------------------------------------------------------

Review request for KDE PIM.


Summary
-------

after the changes, the incidenceUpdate(+d) are receiving the UID instead of pointer. The UID alone doesn't define an incidence. Added the recurrenceId to it.

To keep everything simple, like recurrenceId is implemented in Incidence, and not IncidenceBase, we have added it to IncidenceBase returning an empty KDateTime.


Diffs
-----

  trunk/KDE/kdepimlibs/kcalcore/calendar.h 1165430 
  trunk/KDE/kdepimlibs/kcalcore/calendar.cpp 1165430 
  trunk/KDE/kdepimlibs/kcalcore/incidencebase.h 1165430 
  trunk/KDE/kdepimlibs/kcalcore/incidencebase.cpp 1165430 
  trunk/KDE/kdepimlibs/kcalcore/memorycalendar.h 1165430 
  trunk/KDE/kdepimlibs/kcalcore/memorycalendar.cpp 1165430 

Diff: http://reviewboard.kde.org/r/5070/diff


Testing
-------

In our testing it works. :)


Thanks,

Alvaro

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list