[Kde-pim] Review Request: Kmail: Do not ask in which Adressbook to add a contact when only one exist and use it instead

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5166/#review7248
-----------------------------------------------------------


Thanks for the update, all most perfect now, just a few minor things to correct.


/trunk/KDE/kdepim/libkdepim/addemailaddressjob.cpp
<http://reviewboard.kde.org/r/5166/#comment7362>

    This variable is no longer necessary, since you can just use "canCreateItemCollections.size()", which gives the same result



/trunk/KDE/kdepim/libkdepim/addemailaddressjob.cpp
<http://reviewboard.kde.org/r/5166/#comment7360>

    since this variable is a list, it should be plural, for example "canCreateItemCollections"



/trunk/KDE/kdepim/libkdepim/addemailaddressjob.cpp
<http://reviewboard.kde.org/r/5166/#comment7359>

    remove the trailing whitespace here
    
    Also, use the correct KDEPIM coding style, which is adding spaces at the inside of parenthesis.
    i.e. instead of "foreach(foo)", it should be "foreach( foo ). Same in other places, like if statements, function calls etc, please check those and fix them.



/trunk/KDE/kdepim/libkdepim/addemailaddressjob.cpp
<http://reviewboard.kde.org/r/5166/#comment7363>

    Add a period for full sentence, i.e. change it to "Please create an address book before adding a contact.".
    Also, it is "address book", not "addressbook".
    
    Message box titles should use title-case, i.e. it should be "No Address Book Available".


- Thomas


On 2010-08-27 20:47:02, Nicolas Lécureuil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5166/
> -----------------------------------------------------------
> 
> (Updated 2010-08-27 20:47:02)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> In KMail when we want to add a contact in the addressbook and if there is only one adressbook, a window will open with only one choice.
> With this patch the only adressbook is choosed directly.
> 
> If there is no adressbook available, an empty list open. With this patch a QMessageBox explain to the user what to do.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/libkdepim/addemailaddressjob.h 1128979 
>   /trunk/KDE/kdepim/libkdepim/addemailaddressjob.cpp 1128979 
> 
> Diff: http://reviewboard.kde.org/r/5166/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Nicolas
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/