[Kde-pim] Review Request: Revise connect() call in akonadiconsole

[Stephen Kelly]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4921/#review6860
-----------------------------------------------------------


Your patch is fine, and I indeed missed the connect in the previous revision.

Instead of applying it though I've ported akonadiconsole to KViewStateMaintainer instead.

As for the intent, it may be more clear by looking at http://api.kde.org/4.x-api/kdelibs-apidocs/kdeui/html/classKViewStateSaver.html
The viewstate (what is expanded, selected, and visible in the view) is saved on app close and restored on app start. Additionally the state is saved before the model is reset and restored afterward. Resetting clears the state held in the view because those things are based on QPersistentModelIndexes, and those are cleared by resetting the model.

- Stephen


On 2010-08-07 11:16:50, Brad Hards wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4921/
> -----------------------------------------------------------
> 
> (Updated 2010-08-07 11:16:50)
> 
> 
> Review request for KDE PIM and Stephen Kelly.
> 
> 
> Summary
> -------
> 
> When using akonadiconsole, I see:
> 
> Object::connect: No such slot BrowserWidget::slotBrowserModelAboutToBeReset()
> Object::connect: No such slot BrowserWidget::slotBrowserModelReset()
> 
> I'm guessing that the connect call was missed in http://websvn.kde.org/trunk/KDE/kdepim/akonadiconsole/browserwidget.cpp?r1=1130261&r2=1155538
> 
> However I'm really not confident that I understand the intent here, so would appreciate some adult supervision.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/akonadiconsole/browserwidget.cpp 1160183 
> 
> Diff: http://reviewboard.kde.org/r/4921/diff
> 
> 
> Testing
> -------
> 
> Ran it after, seems to be less noisy.
> 
> 
> Thanks,
> 
> Brad
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/