[Kde-pim] [PATCH] fix threading in KMail

[Thomas McGuire]

Hi Tobias,

On Saturday 07 August 2010 11:32:49 Tobias König wrote:
> the brave users of KMail2 will already have noticed that threading is
> broken in KMail in 4.5 branch and trunk. The reason is that the
> findMessageParent logic in messagelist cannot determine the right parent
> via the In-Reply-To and References field and therefor falls back to
> subject comparison.
> 
> The In-Reply-To and References comparison fails because the used Message-Id
> fields are in the form of '<someuniqueid>' but the used In-Reply-To and
> References fields look like 'someuniqueid', so they are missing the angle
> brackets. The attached patch fixes this inside the messagelist code,
> however I guess the real bug is in libkmime, which (for some unknown
> reason) suddenly strips the angle brackets. Since threading (based on
> messagelist code) works fine in KDE 4.4 this is a regression in KMime
> IMHO.

Patch looks fine.
This is not a regression in KMime: In KDE 4.4, we were still using mimelib, so 
it is rather a regression introduced while porting the messagelist from 
mimelib to KMime.

The documentation of KMime::Headers::Ident::identifiers() mentions that the 
returned identifiers don't contain the angle brackets, so your patch is 
correct.

BTW, the real inconsistency is that the code uses
messageID()->asUnicodeString() instead of using messageID()->identifier(), 
since asUnicodeString() adds angle brackets, whereas identifier() does not.

Regards,
Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20100809/106bf33d/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/