[Kde-pim] Review Request: KCalCore, updates missing recurrenceId

[Sergio Martins]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5070/#review7170
-----------------------------------------------------------



trunk/KDE/kdepimlibs/kcalcore/incidencebase.h
<http://reviewboard.kde.org/r/5070/#comment7308>

    Missing @param recurrenceId :)



trunk/KDE/kdepimlibs/kcalcore/incidencebase.cpp
<http://reviewboard.kde.org/r/5070/#comment7309>

    2 space identation


Just FYI, i replaced the pointer with QString uid because, inside the incidence, we don't have the ::Ptr that contains ourself.

Patch looks fine, commit if it compiles

- Sergio


On 2010-08-19 11:57:06, Alvaro Manera wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5070/
> -----------------------------------------------------------
> 
> (Updated 2010-08-19 11:57:06)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> after the changes, the incidenceUpdate(+d) are receiving the UID instead of pointer. The UID alone doesn't define an incidence. Added the recurrenceId to it.
> 
> To keep everything simple, like recurrenceId is implemented in Incidence, and not IncidenceBase, we have added it to IncidenceBase returning an empty KDateTime.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepimlibs/kcalcore/calendar.h 1165430 
>   trunk/KDE/kdepimlibs/kcalcore/calendar.cpp 1165430 
>   trunk/KDE/kdepimlibs/kcalcore/incidencebase.h 1165430 
>   trunk/KDE/kdepimlibs/kcalcore/incidencebase.cpp 1165430 
>   trunk/KDE/kdepimlibs/kcalcore/memorycalendar.h 1165430 
>   trunk/KDE/kdepimlibs/kcalcore/memorycalendar.cpp 1165430 
> 
> Diff: http://reviewboard.kde.org/r/5070/diff
> 
> 
> Testing
> -------
> 
> In our testing it works. :)
> 
> 
> Thanks,
> 
> Alvaro
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/