[Kde-pim] Review Request: Don't share code between ItemRetriever and FetchHelper

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3844/#review5331
-----------------------------------------------------------

Ship it!


The approach is fine, and I can't spot anything wrong in the code either.

- Volker


On 2010-04-29 12:04:28, Milian Wolff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3844/
> -----------------------------------------------------------
> 
> (Updated 2010-04-29 12:04:28)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Further step in separating the ItemRetriever from the FetchHelper.
> 
> This help removes the code-sharing between the two in order to have free reign in optimizing the queries.
> 
> 
> Diffs
> -----
> 
>   /trunk/kdesupport/akonadi/server/src/handler/fetchhelper.cpp 1120559 
>   /trunk/kdesupport/akonadi/server/src/storage/itemretriever.h 1120559 
>   /trunk/kdesupport/akonadi/server/src/storage/itemretriever.cpp 1120559 
> 
> Diff: http://reviewboard.kde.org/r/3844/diff
> 
> 
> Testing
> -------
> 
> ran KMail / akonadiconsole, no difference as expected.
> 
> 
> Thanks,
> 
> Milian
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/