[Kde-pim] Review Request: Make Akonadi::Job::exec() more scary

Thomas McGuire mcguire at kde.org
Fri Apr 9 20:29:39 BST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3534/
-----------------------------------------------------------

Review request for KDE PIM.


Summary
-------

exec() causes bugs, which are sometimes hard to find. I just wasted another half an hour trying to find a bug, which turned out to be the fault of exec().

This patch will:
- deprecate exec()
- print a warning at runtime

That should make it much easier to identify problem spots.


This addresses bugs bugs, of and tons.
    https://bugs.kde.org/show_bug.cgi?id=bugs
    https://bugs.kde.org/show_bug.cgi?id=of
    https://bugs.kde.org/show_bug.cgi?id=tons


Diffs
-----

  trunk/KDE/kdepimlibs/akonadi/akonadi_export.h 1112990 
  trunk/KDE/kdepimlibs/akonadi/job.h 1112990 
  trunk/KDE/kdepimlibs/akonadi/job.cpp 1112990 

Diff: http://reviewboard.kde.org/r/3534/diff


Testing
-------


Thanks,

Thomas

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list