[Kde-pim] Review Request: Use ItemRetriever as local var instead of inheriting from it in FetchHelper

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3819/
-----------------------------------------------------------

(Updated 2010-04-29 09:24:15.303599)


Review request for KDE PIM.


Changes
-------

integrated Bertjans suggestions, ok to commit now?


Summary
-------

First step towards optimizing the queries in ItemRetriever:

Let the ItemRetriever be used solely for making sure all items are in the database.
To share code, make the generic*Query static and reuse it in the FetchHelper.

I think the latter can even be removed once I merge the queries in the ItemRetriever and the code sharing is gone.
But to keep patches small...


Diffs (updated)
-----

  /trunk/kdesupport/akonadi/server/src/handler/fetchhelper.h 1118978 
  /trunk/kdesupport/akonadi/server/src/handler/fetchhelper.cpp 1118978 
  /trunk/kdesupport/akonadi/server/src/storage/itemretriever.h 1118978 
  /trunk/kdesupport/akonadi/server/src/storage/itemretriever.cpp 1118978 

Diff: http://reviewboard.kde.org/r/3819/diff


Testing
-------

ran kmail & akonadiconsole on my mboxes, no difference.


Thanks,

Milian

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/