[Kde-pim] Review Request: KMail Composer: Add dragged files as attachments without questioning

[Ingo Klöcker]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3720/#review5174
-----------------------------------------------------------


I don't think putting the foreach-loop around the other code is a good idea because this will lead to n questions if the user drops n remote URLs. I propose to do the following:
If all URLs are local files
  attach all local files
else
  ask the user once and do what the user has chosen


trunk/KDE/kdepim/kmail/kmcomposereditor.cpp
<http://reviewboard.kde.org/r/3720/#comment4668>

    In general the new wording is better, but I think now we need to think about using i18np() to get the correct plural form if the user drops more than one URL.


- Ingo


On 2010-04-22 09:43:33, Sascha Peilicke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3720/
> -----------------------------------------------------------
> 
> (Updated 2010-04-22 09:43:33)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Currently, when dropping one or multiple files onto the KMail composer window, a popup dialog asks to either add the files inline or as attachments. IMHO adding inline makes little sense and other mail clients (Thunderbird, Windows Live Mail) automatically add dragged files as attachments. 
> 
> Thus this patch removes that dialog and aligns the composer's drag-n-drop behavior to the competition.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/kmail/kmcomposereditor.cpp 1117232 
> 
> Diff: http://reviewboard.kde.org/r/3720/diff
> 
> 
> Testing
> -------
> 
> works on trunk r1117232
> 
> 
> Thanks,
> 
> Sascha
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/