[Kde-pim] Review Request: Make Akonadi distribution lists work in 4.4

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3827/#review5285
-----------------------------------------------------------

Ship it!


Looks good to me!
Many thanks for taking care of this.

- Thomas


On 2010-04-28 14:33:49, Will Stephenson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3827/
> -----------------------------------------------------------
> 
> (Updated 2010-04-28 14:33:49)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Backport fixes to ContactGroupSearchJob and NepomukFeederAgentBase enabling successful feeding of contact groups into Nepomuk and their querying later by kmail when expanding distribution lists.  Add setLimit(1) on the group search.  Also backport prerequisite changes including #include fixes, ItemSearchJob::akonadiItemIdUri() and ContactGroupSearchJob::setLimit()
> 
> 
> This addresses bug 223034.
>     https://bugs.kde.org/show_bug.cgi?id=223034
> 
> 
> Diffs
> -----
> 
>   branches/KDE/4.4/kdepim/runtime/agents/nepomukfeeder/nepomukfeederagentbase.cpp 1119571 
>   branches/KDE/4.4/kdepim/libkdepim/kaddrbookexternal.cpp 1119571 
>   branches/KDE/4.4/kdepimlibs/akonadi/contact/contactgroupsearchjob.h 1117181 
>   branches/KDE/4.4/kdepimlibs/akonadi/contact/contactgroupsearchjob.cpp 1117181 
>   branches/KDE/4.4/kdepimlibs/akonadi/itemsearchjob.h 1117181 
>   branches/KDE/4.4/kdepimlibs/akonadi/itemsearchjob.cpp 1117181 
> 
> Diff: http://reviewboard.kde.org/r/3827/diff
> 
> 
> Testing
> -------
> 
> Tested with existing and new contact groups.  NepomukFeederAgentBase adds the akonadiItemIdUri for existing contact groups
> 
> 
> Thanks,
> 
> Will
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/