[Kde-pim] Review Request: Fix dangling pointer in MessageList::Core::Model (mOldestItem / mNewestItem)

[pragma at kvirc.net]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3816/#review5261
-----------------------------------------------------------

Ship it!


Looks ok to me :)



- pragma


On 2010-04-27 10:05:56, Milian Wolff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3816/
> -----------------------------------------------------------
> 
> (Updated 2010-04-27 10:05:56)
> 
> 
> Review request for KDE PIM and pragma.
> 
> 
> Summary
> -------
> 
> KMail 2 crashes very often for me due to dangling pointers. This patch adds asserts at a point where the items might get deleted.
> 
> I've first added the two additional conditionals as asserts and hence found those dangling pointers. Hope the 'fix' is correct.
> 
> @Pragma: Are there other places where the items might get deleted?
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/messagelist/core/model.cpp 1118945 
> 
> Diff: http://reviewboard.kde.org/r/3816/diff
> 
> 
> Testing
> -------
> 
> run KMail 2 and switch between mail folders. Used to crash very often, esp. when you collapse groups and switch afterwards. Now it seems to be more stable.
> 
> 
> Thanks,
> 
> Milian
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/