[Kde-pim] Akonadi::Collection::AllRights is wrong

[Stephen Kelly]

David Jarvie wrote:

> The enum value AllRights in Akonadi::Collection::Right does not currently
> include all rights on the collection - contrary to its name and API
> description. It omits the two extra Rights values which were added in 4.4.
> It should be redefined to include them. If this can't be done due to the
> API having to remain unchanged, it should be deprecated and a warning put
> in its API description, and a new enum value created which actually does
> include all Rights.
> 

I believe it would be BIC to change it.

Suggested patch: Can I commit?

kde-devel at bishop:~/kde/src/KDE/kdepimlibs/akonadi{master}$ git diff --cached 
diff --git a/akonadi/collection.h b/akonadi/collection.h
index 35483fd..92a4f13 100644
--- a/akonadi/collection.h
+++ b/akonadi/collection.h
@@ -94,7 +94,8 @@ class AKONADI_EXPORT Collection : public Entity
       CanLinkItem = 0x40,               ///< Can create links to existing 
items in this virtual collection @since 4.4
       CanUnlinkItem = 0x80,             ///< Can remove links to items in 
this virtual collection @since 4.4
       AllRights = (CanChangeItem | CanCreateItem | CanDeleteItem |
-                   CanChangeCollection | CanCreateCollection | 
CanDeleteCollection) ///< Has all rights on this storage collection
+                   CanChangeCollection | CanCreateCollection | 
CanDeleteCollection), ///< @deprecated Use FullRights instead. Has all 
rights on this storage collection
+      FullRights = 0xffffffff           ///< Has all rights on this storage 
collection
     };
     Q_DECLARE_FLAGS(Rights, Right)
 


_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/