[Kde-pim] Review Request: Use config for Akonadi socket directory to alson determine where to put the MySQL socket

[Volker Krause]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1520/#review2258
-----------------------------------------------------------


Does that mean existing config files will fail to work, ie. existing users will end up with a non-working Akonadi? If that's the case we need to add some fallback code for that config option I guess.

- Volker


On 2009-09-04 18:16:28, Kevin Krammer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1520/
> -----------------------------------------------------------
> 
> (Updated 2009-09-04 18:16:28)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> The path where to put akonadiserver.socket can be configured using
> 
> [Connection]
> SocketDirectory=path
> 
> MySQL's socket was always put into the database directory.
> 
> This uses the same path for both sockets
> 
> 
> Diffs
> -----
> 
>   /trunk/kdesupport/akonadi/server/src/akonadi.cpp 1019884 
>   /trunk/kdesupport/akonadi/server/src/storage/dbconfig.h 1019884 
>   /trunk/kdesupport/akonadi/server/src/storage/dbconfig.cpp 1019884 
> 
> Diff: http://reviewboard.kde.org/r/1520/diff
> 
> 
> Testing
> -------
> 
> Without the section, mysql.socket now gets created in the Akonadi data directory. With config, at the desired place.
> 
> Known drawbacks: when changing the directory one also has to change MySQL Driver "option" config.
> 
> 
> Thanks,
> 
> Kevin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/