[Kde-pim] Review Request: Catch Clicks in ContactViewer

[Tom Albers]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1660/
-----------------------------------------------------------

Review request for KDE PIM and Tobias Koenig.


Summary
-------

This patchs adds the possibility to catch the clicks made in ContactViewer. In the composer of Mailody I use the dialog to show the details of a contact. When the user clicks on an e-mail address, that click should not end up opening a new composer, but add the address to the currently opened composer. This patch makes ContactViewer optinonally emit a signal if there is a click on an e-mailaddress (and url while is was there). API is identical to the one from KTextBrowser.

I've added a method to ContactViewerDialog to get to the ContactViewer, to get to the signals. I think this is better for future expansions. If you don't like it, the dialog can forward the two signals. I'm happy to change that.


Diffs
-----

  /trunk/KDE/kdepimlibs/akonadi/contact/contactviewer.h 1025683 
  /trunk/KDE/kdepimlibs/akonadi/contact/contactviewer.cpp 1025683 
  /trunk/KDE/kdepimlibs/akonadi/contact/contactviewerdialog.h 1025683 
  /trunk/KDE/kdepimlibs/akonadi/contact/contactviewerdialog.cpp 1025683 

Diff: http://reviewboard.kde.org/r/1660/diff


Testing
-------

Mailody uses it, see screenie


Screenshots
-----------


  http://reviewboard.kde.org/r/1660/s/206/


Thanks,

Tom

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/