[Kde-pim] Review Request: Automatically start akonadi when necessary

[Bertjan Broeksema]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1090/#review2341
-----------------------------------------------------------

Ship it!


Looks good to me. Please make sure you adhere to the coding style before committing.

- Bertjan


On 2009-09-12 01:38:24, Robert Marmorstein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1090/
> -----------------------------------------------------------
> 
> (Updated 2009-09-12 01:38:24)
> 
> 
> Review request for KDE PIM, Jason Kasper and Bertjan Broeksema.
> 
> 
> Summary
> -------
> 
> Here is a new patch that should do things better.  We access Akonadi in several different places in the configuration dialog code.  I have tried to take into account the possibility that the Akonadi server will disappear (be shut down or crash) in between these function calls, but I have probably missed something.  
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/kpilot/conduits/akonadibase/akonadisetupwidget.h 1021325 
>   trunk/KDE/kdepim/kpilot/conduits/akonadibase/akonadisetupwidget.cc 1021325 
> 
> Diff: http://reviewboard.kde.org/r/1090/diff
> 
> 
> Testing
> -------
> 
> Pulled up settings dialog.  Akonadi server was started and I was able to select a collection.  Turned off akonadi server using akonadictl.  The error overlay WAS displayed and the collection dialog was disabled.  Started akonadi server again, overlay disappeared and I was again able to configure a collections.  Then turned off akonadi server and started a sync.  The akonadi server was started and I synced succesfully.
> 
> 
> Thanks,
> 
> Robert
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/