[Kde-pim] Review Request: Expandable/Collapsible "To" and "Cc" fields in KMail

[Torgny Nyblom]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1492/
-----------------------------------------------------------

(Updated 2009-09-07 16:44:53.681158)


Review request for KDE PIM.


Changes
-------

Reworked the patch according to Thomas comments. 


Summary
-------

Makes the "To" and "Cc" fields collapsible if more then three addresses are present in the respective field.
Image is borrowed from the same function for attachments, but code is slightly different.

As of now this is just enabled for "Fancy headers" but the concept is easily expanded into all kinds of header styles.


Diffs (updated)
-----

  /trunk/KDE/kdepim/kmail/pics/attachmentQuicklistClosed.png UNKNOWN 
  /trunk/KDE/kdepim/kmail/pics/attachmentQuicklistOpened.png UNKNOWN 
  /trunk/KDE/kdepim/kmail/stringutil.h 1020776 
  /trunk/KDE/kdepim/kmail/stringutil.cpp 1020776 
  /trunk/KDE/kdepim/kmail/urlhandlermanager.cpp 1020776 
  /trunk/KDE/kdepim/kmail/kmreaderwin.h 1020776 
  /trunk/KDE/kdepim/kmail/kmreaderwin.cpp 1020776 
  /trunk/KDE/kdepim/kmail/headerstyle.cpp 1020776 

Diff: http://reviewboard.kde.org/r/1492/diff


Testing
-------

Built, opened test email in diffent header styles and expanded/collapsed the headers.


Screenshots
-----------

Collapsed
  http://reviewboard.kde.org/r/1492/s/195/
One expanded, one collapsed
  http://reviewboard.kde.org/r/1492/s/196/
Expanded
  http://reviewboard.kde.org/r/1492/s/197/


Thanks,

Torgny

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/