[Kde-pim] Plugin Question re Kontact Headers

[Allen Winter]

On Thursday 17 September 2009 12:25:24 pm you wrote:
> On Thursday 17 September 2009 15:50:42 Allen Winter wrote:
> > On Wednesday 16 September 2009 5:57:26 am Frank Osterfeld wrote:
> > > On Tuesday 15 September 2009 23:08:45 Allen Winter wrote:
> > > > On Thursday 10 September 2009 11:12:20 am Allen Winter wrote:
> > > > > Ok then.
> > > > > Unless there are further strenuous objections, I'll plan to move
> > > > > kontactinterfaces back to kdepimlibs well before the 4.4 soft freeze
> > > > > so we have time to make at least a basic review.
> > > >
> > > > Done.
> > > > Please start reviewing kdepimlibs/kontactinterfaces.
> > > > Pay particular attention to BC problems we might encounter and the API
> > > >  design.
> > > >
> > > > So far I see:
> > > > license ok
> > > > dpointers are there
> > > > no inline stuff in headers
> > > > 0 Krazy issues
> > > > clearly we did put some effort into this before
> > >
> > > IIRC there is usage QList* in Plugin, those shouldn't be pointers, I
> > > think.
> > 
> > true.
> > So you'd like
> > Plugin::insertNewAction(KAction *action) to be changed to
> > Plugin::insertNewAction(KAction &action) ?
> > 
> > and Plugin would keep a list of KActions instead of a list of pointers to
> >  KActions?
> 
> No, the KActions should be pointers of couse, being QObjects. I was talking 
> about QList<KAction*>* newActions() and QList<KAction>* syncActions() in 
> Plugin. Those QLists shouldn't be pointers themselves.
> 
Ok, done.

I'll increase the KONTACT_PLUGIN_VERSION to 8 sometime soon so all
the 3rd party plugin folks should be ready to change their .desktop files
to say X-KDE-KontactPluginVersion=8

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/