[Kde-pim] Review Request: Internationalize the filter log

[Ingo Klöcker]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1931/#review2765
-----------------------------------------------------------

Ship it!


Apparently, it was me who added those FIXMEs (4 years and 8 months ago!). I have no idea what I had in mind back then. The only thing I can think of is that I wanted to replace
  label() + " \"" + Qt::escape( argsAsString() ) + "\""
by
  i18nc( "some useful comment", "%1 \"%2\"" ).arg( label() ).arg( Qt::escape( argsAsString() ) )
but I don't know whether that's really useful. *shrug*

I'm okay with simply removing those FIXMEs.

- Ingo


On 2009-10-22 14:28:10, Jaime Torres wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1931/
> -----------------------------------------------------------
> 
> (Updated 2009-10-22 14:28:10)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Apply, somehow, the FIXMEs
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/kmfilteraction.cpp 1038959 
> 
> Diff: http://reviewboard.kde.org/r/1931/diff
> 
> 
> Testing
> -------
> 
> The logs are the same for the default language.
> 
> 
> Thanks,
> 
> Jaime
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/