[Kde-pim] Review Request: Add Tooltip to IdentityCombo

[Ingo Klöcker]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1920/#review2744
-----------------------------------------------------------


I don't object to the patch, but I wonder why the identity is named "Unnamed" in the first place. Is it because the user was too lazy to chose a useful name? Maybe we should change the way identities are created. If one creates a new identity one is first asked for its name and whether one wants to copy the values of another identity. Maybe we should remove the need to specify a name for the identity. Instead we could use the email address as default name of the identity. Of course, the user could still change the name of the identity afterwards, but I guess most users won't want to do this. Obviously, this change would render your patch mostly superfluous because most of the time the tooltip wouldn't contain any new information. In particular, there won't be an identity called "Unnamed" anymore unless the user explicitly chose this name.

- Ingo


On 2009-10-21 14:16:44, Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1920/
> -----------------------------------------------------------
> 
> (Updated 2009-10-21 14:16:44)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Adding a tooltip to the IdentityCombo displaying the full email address of the current selected Identity. The reason for that is, that Identities like "Unnamed" do not really provide useful information.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepimlibs/kpimidentities/identitycombo.h 1038538 
>   trunk/KDE/kdepimlibs/kpimidentities/identitycombo.cpp 1038538 
> 
> Diff: http://reviewboard.kde.org/r/1920/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> An identity combo with the tooltip
>   http://reviewboard.kde.org/r/1920/s/232/
> 
> 
> Thanks,
> 
> Martin
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/