[Kde-pim] Review Request: KMail: Clicking the HTML status bar switches display mode

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2017/#review2869
-----------------------------------------------------------


Thanks for the patch.
Two things: First, I think the action should be disabled if the current mail is not a HTML mail, as the action isn't useful for plaintext-only mails.
Secondly, I am not sure if the actions should be added to the menu, there is so much stuff in it, already.
I also think that maybe showing a tooltip for the HTML status bar that says that clicking it changes the mode would be nice.


/trunk/KDE/kdepim/kmail/htmlstatusbar.h
<http://reviewboard.kde.org/r/2017/#comment2249>

    reimplemented protected methods are usually put in the protected section, not private.



/trunk/KDE/kdepim/kmail/htmlstatusbar.cpp
<http://reviewboard.kde.org/r/2017/#comment2248>

    put the opening { bracket in a new line


- Thomas


On 2009-10-29 20:55:10, James Bendig wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2017/
> -----------------------------------------------------------
> 
> (Updated 2009-10-29 20:55:10)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Clicking the HTML status bar in a message switches the display mode between HTML and plain text. It's implemented as an action so a user can configure a shortcut as well. Unlike as stated in the JJ, "Clicking the HTML status bar should switch display mode," the message does not have to have both HTML and plain text. Seems useful to be able to toggle back from HTML to plain text after clicking the "... activate formatted HTML display for this message by clicking here." URL.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/htmlstatusbar.h 1042445 
>   /trunk/KDE/kdepim/kmail/htmlstatusbar.cpp 1042445 
>   /trunk/KDE/kdepim/kmail/kmail_part.rc 1042445 
>   /trunk/KDE/kdepim/kmail/kmmainwin.rc 1042445 
>   /trunk/KDE/kdepim/kmail/kmreadermainwin.rc 1042445 
>   /trunk/KDE/kdepim/kmail/kmreaderwin.h 1042445 
>   /trunk/KDE/kdepim/kmail/kmreaderwin.cpp 1042445 
> 
> Diff: http://reviewboard.kde.org/r/2017/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> James
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/