[Kde-pim] Review Request: Maemo fixes in Kcal

[David Jarvie]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1489/#review2644
-----------------------------------------------------------



trunk/KDE/kdepimlibs/kcal/duration.cpp
<http://reviewboard.kde.org/r/1489/#comment1959>

    The durations are _not_ strictly equal if one is in terms of seconds and the other in terms of days. When a day crosses a daylight saving time change, the two produce different results. So this change should not be implemented.



trunk/KDE/kdepimlibs/kcal/incidencebase.h
<http://reviewboard.kde.org/r/1489/#comment1960>

    A clearer wording would be:
    
    Call this to notify the observers when the IncidenceBase object is about to be changed. Call updated() after the changes have been completed.


- David


On 2009-10-14 06:57:11, Alvaro Manera wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1489/
> -----------------------------------------------------------
> 
> (Updated 2009-10-14 06:57:11)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> This is a combined patch of all the changes we have in our trunk, before the implementation of the RecurrenceID.
> 
> These changes include:
> * Contacts in the incidence. (I don't know if you need this, as you have the addressbook) ¿?
> * Some small fixes in our side (like copy constructor in listbase).
> * Handling the updates. This fixes the bug that you end up having a duplicate entry in the Hash table when modifying an event. 
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepimlibs/kcal/alarm.cpp 1034333 
>   trunk/KDE/kdepimlibs/kcal/calendarlocal.h 1034333 
>   trunk/KDE/kdepimlibs/kcal/calendarlocal.cpp 1034333 
>   trunk/KDE/kdepimlibs/kcal/calendarnull.h 1034333 
>   trunk/KDE/kdepimlibs/kcal/calendarnull.cpp 1034333 
>   trunk/KDE/kdepimlibs/kcal/duration.cpp 1034333 
>   trunk/KDE/kdepimlibs/kcal/event.cpp 1034333 
>   trunk/KDE/kdepimlibs/kcal/incidence.cpp 1034333 
>   trunk/KDE/kdepimlibs/kcal/incidencebase.h 1034333 
>   trunk/KDE/kdepimlibs/kcal/incidencebase.cpp 1034333 
>   trunk/KDE/kdepimlibs/kcal/journal.cpp 1034333 
>   trunk/KDE/kdepimlibs/kcal/listbase.h 1034333 
>   trunk/KDE/kdepimlibs/kcal/todo.cpp 1034333 
> 
> Diff: http://reviewboard.kde.org/r/1489/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alvaro
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/