[Kde-pim] Review Request: Building Blogilo out of kdepim

[Allen Winter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1791/#review2555
-----------------------------------------------------------

Ship it!


looks fine

- Allen


On 2009-10-05 19:31:07, Mehrdad Momeny wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1791/
> -----------------------------------------------------------
> 
> (Updated 2009-10-05 19:31:07)
> 
> 
> Review request for KDE PIM and Allen Winter.
> 
> 
> Summary
> -------
> 
> This patch will add a simple check to know if cmake is out of kdepim, and add needed definition and includes to build blogilo!
> I think we need this for every app, that users can build them without the whole module! (It's my problem at first! that I don't like to have kde trunk installation!) what do you guys do? :D
> 
> It's based on a suggestion for same problem for ksysguard, here is it's thread discussion: http://lists.kde.org/?l=kde-core-devel&m=125434047602082&w=2
> 
> What do you think?
> I don't know if i have to discuss about this somewhere else!
> And BTW, I'm the maintainer of blogilo, and I'm new to kdepim :D
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/blogilo/CMakeLists.txt 1030631 
>   trunk/KDE/kdepim/blogilo/blogilo-separate.cmake PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/1791/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mehrdad
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/