[Kde-pim] Review Request: Fix messageviewer build with --as-needed

[Daniel Black]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1870/#review2673
-----------------------------------------------------------

Ship it!


looks good. programs should specify all the libraries they directly use. --as-needed is a good way of picking this up.

- Daniel


On 2009-10-16 23:45:09, Jonathan Callen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1870/
> -----------------------------------------------------------
> 
> (Updated 2009-10-16 23:45:09)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> When using LDFLAGS="-Wl,--as-needed", libmessageviewer currently fails to build.  This patch adds the needed libraries to allow the build to succeed.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdepim/messageviewer/CMakeLists.txt 1034263 
> 
> Diff: http://reviewboard.kde.org/r/1870/diff
> 
> 
> Testing
> -------
> 
> With this patch, the library builds properly
> 
> 
> Thanks,
> 
> Jonathan
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/