[Kde-pim] Review Request: KMail: Clicking the HTML status bar switches display mode

[James Bendig]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2017/
-----------------------------------------------------------

(Updated 2009-10-30 19:09:31.643228)


Review request for KDE PIM.


Changes
-------

Fixed code formatting.
Removed "HTML Display Mode" toggle action from menus.
Changed HTML Display Mode toggle action to only work on HTML and multipart/alternative messages.
Added tooltip to HTML status bar when HTML or multipart/alternative message is being viewed that says it can be clicked to toggle between HTML and plain text.
Added two new states to HTML status bar: multipart/alternative message viewed as HTML and multipart/alternative message viewed as plain text.


The text for the two new HTML status bar states seem a little awkward to me but I'm not sure what would sound better. The text in the patch are "HTML Message Part" and "No HTML Message Part." They are consistent with the existing text: "HTML Message" and "No HTML Message" though.


Summary
-------

Clicking the HTML status bar in a message switches the display mode between HTML and plain text. It's implemented as an action so a user can configure a shortcut as well. Unlike as stated in the JJ, "Clicking the HTML status bar should switch display mode," the message does not have to have both HTML and plain text. Seems useful to be able to toggle back from HTML to plain text after clicking the "... activate formatted HTML display for this message by clicking here." URL.


Diffs (updated)
-----

  /trunk/KDE/kdepim/kmail/htmlstatusbar.h 1042445 
  /trunk/KDE/kdepim/kmail/htmlstatusbar.cpp 1042445 
  /trunk/KDE/kdepim/kmail/kmreaderwin.h 1042445 
  /trunk/KDE/kdepim/kmail/kmreaderwin.cpp 1042445 

Diff: http://reviewboard.kde.org/r/2017/diff


Testing
-------


Thanks,

James

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/