[Kde-pim] Review Request: adds kmail support for RFC2369, List-* headers to display in preview pane with links to URLs

[Ingo Klöcker]

On Friday 23 October 2009, Daniel Black wrote:
> > On 2009-10-22 16:28:43, Thomas McGuire wrote:
> > > /trunk/KDE/kdepim/kmail/messageactions.cpp, line 182
> > > <http://reviewboard.kde.org/r/1768/diff/4/?file=13176#file13176li
> > >ne182>
> > >
> > >     Mailing-List Information is too long IMHO, just use "Mailing
> > > List" (also without the hyphen, since that is what is used in the
> > > folder menu)
> >
> >  wrote:
> >     Mailing-List" was chosen for consistency with "Reply to
> > Mailing-List". Shortening is fine though Ingo is suggesting putting
> > the List-id here too. Can submenu's have header text? Either that
> > or "Mailing-List - KDE PIM". I could drop it but sometimes there is
> > good information here as to what the specific list topic is.
>
> 1: "Mailing List" - count 4 (excluding warnings/debug)
> $ grep -i Mailing\ List *.cpp | fgrep -v '//'
> kmmainwidget.cpp:  mFolderMailingListPropertiesAction = new
> KAction(i18n("&Mailing List Management..."), this);
> mailinglist-magic.cpp:  if ( header.isNull() || header.left(13 ) !=
> "mailing list" mailinglist-magic.cpp:      kDebug()<<"Serious mailing
> list header parsing error !"; mailinglist-magic.cpp:   
> kDebug()<<"Mailing list ="<<header.mid( start, end - start );
> mailinglistpropertiesdialog.cpp:  QGroupBox *mlGroup = new QGroupBox(
> i18n("Associated Mailing List" ), this );
> mailinglistpropertiesdialog.cpp:  mHoldsMailingList = new QCheckBox(
> i18n("&Folder holds a mailing list"), mlGroup );
> mailinglistpropertiesdialog.cpp:  label = new QLabel( i18n("Mailing
> list description:"), mlGroup ); mailinglistpropertiesdialog.cpp: 
> kDebug()<< "Detecting mailing list"; mailinglistpropertiesdialog.cpp:
>              i18n("KMail was unable to detect a mailing list in this
> folder. " mailinglistpropertiesdialog.cpp:    kWarning()<<"Wrong
> entry in the mailing list entry combo!";
> mailinglistpropertiesdialog.cpp:    kWarning()<<"Wrong entry in the
> mailing list entry combo!"; mailinglistpropertiesdialog.cpp:   
> kWarning()<<"Wrong entry in the mailing list entry combo!";
>
> 2: "Mailing-List" - count 9
> $ grep -i "Mailing-" *.cpp
> kmmainwidget.cpp:  mListFilterAction->setText( i18n("Filter on
> Mailing-List...") ); kmmainwidget.cpp:    mListFilterAction->setText(
> i18n( "Filter on Mailing-List %1...", lname ) ); kmmainwidget.cpp:   
>                                       i18n( "New Message t&o
> Mailing-List..." ), kmmainwidget.cpp:  mListFilterAction = new
> KAction(i18n("Filter on Mailing-&List..."), this);
> kmsearchpatternedit.cpp: contain legitimate Mailing-List stuff
> mailinglist-magic.cpp: contain legitimate Mailing-List stuff
> mailinglist-magic.cpp:  QString header = message->headerField(
> "Mailing-List"); mailinglist-magic.cpp:  header_name =
> "Mailing-List";
> messageactions.cpp:  mReplyListAction = new KAction(
> KIcon("mail-reply-list"), i18n("Reply to Mailing-&List..."), this );
> messageactions.cpp:  mMailingListActionMenu =  new
> KActionMenu(i18nc("Message->","Mailing-&List" ), this);
> searchwindow.cpp:  mReplyListAction  = new
> KAction(KIcon("mail-reply-list"), i18n("Reply to Mailing-&List..."),
> this);
>
> To convert to "Mailing List"? I didn't want to be the one to upset
> the translators :-) sed -i -e "s/Mailing-/Mailing /g'
> kmmainwidget.cpp messageactions.cpp searchwindow.cpp

I think it's okay to make this change. But probably not at part of this 
patch.


Regards,
Ingo
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-pim/attachments/20091023/60c390ab/attachment.sig>
-------------- next part --------------
_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/