[Kde-pim] Review Request: incidence.cpp:622: warning: enumeration value 'None' not handled in switch

[Guy Maurel]

> On 2009-10-21 07:03:35, Torgny Nyblom wrote:
> > For consistency you should use the same value for the "None" case in this patch as in the other for the same variable.
> > Either go with the default (seems to be "accepted") or return another meaningful string (might be empty, but as I don't know the code...)

right, thanks


- Guy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1906/#review2735
-----------------------------------------------------------


On 2009-10-19 18:28:42, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1906/
> -----------------------------------------------------------
> 
> (Updated 2009-10-19 18:28:42)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> The dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=kdelibs
> reports:
> /.../kdepim/kresources/kolab/kcal/incidence.cpp:622: warning: enumeration value 'None' not handled in switch
> 
> at
> static QString attendeeStatusToString( KCal::Attendee::PartStat status )
> 
> my proposal:add the enumeration value 'None' in the switch
> see: incidence-gm-21.diff
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kresources/kolab/kcal/incidence.cpp 1031659 
> 
> Diff: http://reviewboard.kde.org/r/1906/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/