[Kde-pim] Review Request: Server url in errormessages for pop3 errors

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1893/#review2731
-----------------------------------------------------------


The change of ERR_COULD_NOT_LOGIN seems correct, please commit.
The change for ERR_COULD_NOT_CONNECT seems to be wrong. It was wrong before as well.
If you look at the source of KIO::buildErrorString (http://api.kde.org/4.x-api/kdelibs-apidocs/kio/html/global_8cpp_source.html), you'll see that it expects only the actual hostname as an error text, not an actual explanation. If the text contains an actual explanation, like in ERR_COULD_NOT_CONNECT in POP3, it should use ERR_SLAVE_DEFINED, because that just uses the text supplied as an argument to error() as the actual text.

This needs to be tested since I'm not quite sure if KMail actually does use buildErrorString() to display errors from the KIO slave. It should do that, though.
Note that there are many places where the error() function is used wrong, in the actual KIO slaves, but also in the base class KTCPSlaveBase. Those should all be fixed.
If not, there are wrong error messages, like in the ERR_COULD_NOT_CONNECT case, which will result in the following:
"Could not connect to host Your POP3 server does not support TLS. Disable TLS, if you want to connect without encryption.."
Notice how the %1 from "Could not connect to host %1." from KIO::buildErrorString() was wrongly exchanged.

- Thomas


On 2009-10-19 13:29:42, Torgny Nyblom wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1893/
> -----------------------------------------------------------
> 
> (Updated 2009-10-19 13:29:42)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Add the server url to some error messages from the pop3 resource.
> 
> 
> This addresses bug 211019.
>     https://bugs.kde.org/show_bug.cgi?id=211019
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepimlibs/kioslave/pop3/pop3.cpp 1036171 
> 
> Diff: http://reviewboard.kde.org/r/1893/diff
> 
> 
> Testing
> -------
> 
> Sent emails, no pop3 server to test error messages against.
> 
> 
> Thanks,
> 
> Torgny
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/