[Kde-pim] Review Request: whitespace cleanup of kmail messageactions.cpp and kmmainwidget.cpp

[Thomas McGuire]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1956/#review2842
-----------------------------------------------------------


I'd say the patch is ok, but Volker disagrees, and since he does all the time-consuming merging work, I'd say drop this patch for now.
Please close the review request.
Sorry, but merging stuff with SVN really sucks in that regard.

- Thomas


On 2009-10-24 03:41:12, Daniel Black wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1956/
> -----------------------------------------------------------
> 
> (Updated 2009-10-24 03:41:12)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> whitespace cleanup of some files discovered when doing review 1768.
> 
> svn diff -x -w messageactions.cpp kmmainwidget.cpp
> shows empty so this is really only whitespace. SLOTs and SIGNAL internal bracketing has not been changed.
> 
> This aids developers changing these two files of some cleaner syntax.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/kmmainwidget.cpp 1039626 
>   /trunk/KDE/kdepim/kmail/messageactions.cpp 1039626 
> 
> Diff: http://reviewboard.kde.org/r/1956/diff
> 
> 
> Testing
> -------
> 
> 9 out of 82 hunks didn't patch nicely against kdepim-4.3.2 however the rest compiled and ran ok. I couldn't seen any errors with the Failed hunks apart from they were made against svn and didn't patch well on 4.3.2.
> 
> 
> Thanks,
> 
> Daniel
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/