[Kde-pim] Review Request: adds kmail support for RFC2369, List-* headers to display in preview pane with links to URLs

Daniel Black daniel.subs at internode.on.net
Mon Oct 19 14:10:36 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1768/
-----------------------------------------------------------

(Updated 2009-10-19 13:10:35.912889)


Review request for KDE PIM.


Changes
-------

part 1:

preliminary changes to extract more information out of a message. Please don't be too harsh on the commenting - there were none to start with and I didn't write the class.

work on context menu work continuing.


Summary
-------

This patch displays the List{-ID,post,subscriber,unsubscribe,archive,help,owner} (<a href="http://tools.ietf.org/html/rfc2369">RFC2369</a> List-ID is RFC2919) URLs of email header fields on the view plane in kmail. The display occurs on styles: Enterprise, Fancy, Standard, and Long. The format is:
List: Linux Australia  Post Unsubscribe(http mailto) Subscribe(http mailto) Archive Help 
The Post, Archive and Help are links to the single URL present. The Subscribe/Unsubcribe have two links so the http and mailto, extracted from the URL protocol, are links to those two options. Only list tags that exist are show.
Visual separation from the title and Post.... is a bit weak. Is "List: List Title <Post....>" better?


Diffs (updated)
-----

  /trunk/KDE/kdepim/kmail/mailinglist-magic.h 1037430 
  /trunk/KDE/kdepim/kmail/mailinglist-magic.cpp 1037430 

Diff: http://reviewboard.kde.org/r/1768/diff


Testing
-------

tested on kmail-1.12.1 (kde-4.3.1)


Thanks,

Daniel

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/



More information about the kde-pim mailing list