[Kde-pim] Review Request: Maemo fixes in Kcal

[Alvaro Manera]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1489/
-----------------------------------------------------------

(Updated 2009-10-21 14:48:51.218395)


Review request for KDE PIM.


Changes
-------

New version of the diff. I forgot to add the changes in icalformat_p.cpp
To answer also to Allen: It is not so easy to use the Person to store the Contact. By the RFC the Contact can be a lot of things, and not necessary a Name / Email. We are storing it to be able to export it afterwards (round trip compatibility). And that's why I realized that I forgot to include the icalformat_p diff.


Summary
-------

This is a combined patch of all the changes we have in our trunk, before the implementation of the RecurrenceID.

These changes include:
* Contacts in the incidence. (I don't know if you need this, as you have the addressbook) ¿?
* Some small fixes in our side (like copy constructor in listbase).
* Handling the updates. This fixes the bug that you end up having a duplicate entry in the Hash table when modifying an event. 


Diffs (updated)
-----

  trunk/KDE/kdepimlibs/kcal/alarm.cpp 1035467 
  trunk/KDE/kdepimlibs/kcal/calendarlocal.h 1035467 
  trunk/KDE/kdepimlibs/kcal/calendarlocal.cpp 1035467 
  trunk/KDE/kdepimlibs/kcal/calendarnull.h 1035467 
  trunk/KDE/kdepimlibs/kcal/calendarnull.cpp 1035467 
  trunk/KDE/kdepimlibs/kcal/event.cpp 1035467 
  trunk/KDE/kdepimlibs/kcal/icalformat_p.cpp 1035467 
  trunk/KDE/kdepimlibs/kcal/incidence.cpp 1035467 
  trunk/KDE/kdepimlibs/kcal/incidencebase.h 1035467 
  trunk/KDE/kdepimlibs/kcal/incidencebase.cpp 1035467 
  trunk/KDE/kdepimlibs/kcal/journal.cpp 1035467 
  trunk/KDE/kdepimlibs/kcal/listbase.h 1035467 
  trunk/KDE/kdepimlibs/kcal/todo.cpp 1035467 

Diff: http://reviewboard.kde.org/r/1489/diff


Testing
-------


Thanks,

Alvaro

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/