[Kde-pim] Review Request: Migrate settings to KConfigXT

[Thomas McGuire]

> On 2009-10-15 11:58:40, Will Stephenson wrote:
> > /trunk/KDE/kdepim/kmail/kmail.kcfg.cmake, line 577
> > <http://reviewboard.kde.org/r/1536/diff/2/?file=11215#file11215line577>
> >
> >     Sorry for the late comments, but I noticed that the allowable values of headerStyle are not clearly specified while handling a bug.
> >     
> >     Why not make this an external enum (KMail::HeaderStyle::Type)? This would be clearer semantics.
> >     
> >     You'd have to add a type() accessor to HeaderStyle that returns its type.

If that works with KConfigXT and is compatible with the old format, I agree with this.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1536/#review2657
-----------------------------------------------------------


On 2009-09-10 13:14:41, Torgny Nyblom wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1536/
> -----------------------------------------------------------
> 
> (Updated 2009-09-10 13:14:41)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Move some settings to KConfigXT.
> 
> Never used KConfigXT before so please take a good look :)
> Also some settings have "???" as "label", what should these have instead?
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kmail/kmmainwidget.h 1021961 
>   /trunk/KDE/kdepim/kmail/kmmainwidget.cpp 1021961 
>   /trunk/KDE/kdepim/kmail/kmreaderwin.h 1021961 
>   /trunk/KDE/kdepim/kmail/kmreaderwin.cpp 1021961 
>   /trunk/KDE/kdepim/kmail/configuredialog.cpp 1021961 
>   /trunk/KDE/kdepim/kmail/headerstyle.cpp 1021961 
>   /trunk/KDE/kdepim/kmail/kmail.kcfg.cmake 1021961 
> 
> Diff: http://reviewboard.kde.org/r/1536/diff
> 
> 
> Testing
> -------
> 
> Compiles, seems to store/read settings ok.
> 
> 
> Thanks,
> 
> Torgny
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/