[Kde-pim] Review Request: find_package support for libkleo

[Christophe Giboudeaux]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1967/#review2802
-----------------------------------------------------------


Please give more informations: Does your project concern KHTML or Konqueror ?
If it's KHTML, this patch doesn't make sense: kdelibs cannot depend on kdepim,
If it's Konqueror, you would make kdepim a dependency for kdebase(/apps) which also doesn't sound correct.

For any case: the stuff in kdepim doesn't have to be BC. 
As long as libkleo is in kdepim, it shouldn't install any cmake file (that's why `find_package(Kdepim)` will return a fatal error).
If you really want to use libkleo, please consider adding a FindLibKleo.cmake in your project instead.

About the patch itself: KleoLibraryDepends.cmake contains all the kdepim dependencies. That makes your file bigger for nothing (you only need two lines from the generated file).




- Christophe


On 2009-10-24 23:48:22, Eduardo Robles Elvira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1967/
> -----------------------------------------------------------
> 
> (Updated 2009-10-24 23:48:22)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> Currently libkleo is not being used by any application outside kdepim, but I'm working in a project which involves using libkleo in konqueror/khtml, which means I need to link to it from outside kdepim. 
> 
> This patch adds a KleoConfig.cmake file that will let anyone use find_package(Kleo REQUIRED) in any other KDE4 application to be able to easily find and use libkleo.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/libkleo/CMakeLists.txt 1034981 
>   /trunk/KDE/kdepim/libkleo/KleoConfig.cmake.in PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/1967/diff
> 
> 
> Testing
> -------
> 
> So far I've tested it locally and it works as expected, I can find Libkleo, include its headers and link to the library itself.
> 
> 
> Thanks,
> 
> Eduardo
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/