[Kde-pim] Review Request: knconfigwidgets.cpp:857: warning: enumeration value 'Iso' not handled in switch

[Guy Maurel]

> On 2009-10-21 07:06:23, Torgny Nyblom wrote:
> > /trunk/KDE/kdepim/knode/knconfigwidgets.cpp, line 861
> > <http://reviewboard.kde.org/r/1905/diff/1/?file=12962#file12962line861>
> >
> >     didn't you mean to put "break;" on a non commented line?
> >     
> >     Same for the next line

you are right, thanks


- Guy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1905/#review2736
-----------------------------------------------------------


On 2009-10-19 17:16:03, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1905/
> -----------------------------------------------------------
> 
> (Updated 2009-10-19 17:16:03)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> The dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=kdelibs
> reports:
> /.../kdepim/knode/knconfigwidgets.cpp:857: warning: enumeration value 'Iso' not handled in switch
> /.../kdepim/knode/knconfigwidgets.cpp:857: warning: enumeration value 'Rfc' not handled in switch
> 
> at
> void KNode::ReadNewsGeneralWidget::load()
> 
> my proposal: add the two enumeration value in the switch
> see: knconfigwidgets-gm-20.diff
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/knode/knconfigwidgets.cpp 1031659 
> 
> Diff: http://reviewboard.kde.org/r/1905/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/