[Kde-pim] Review Request: Send "QUIT" when closing an smtp transaction

[Torgny Nyblom]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1891/
-----------------------------------------------------------

Review request for KDE PIM.


Summary
-------

Send "QUIT" when ending an SMTP transaction if possible.

If the response is complete I see no reason to close without sending QUIT as the RFC states that a connection must end with either party sending this.

Probably should try and sent QUIT in the other cases of "smtp_close( false )" as well but as they seem to involve incomplete send or recieve calls the socket might be down.


This addresses bug 94748.
    https://bugs.kde.org/show_bug.cgi?id=94748


Diffs
-----

  /trunk/KDE/kdepimlibs/kioslave/smtp/smtp.cpp 1036171 

Diff: http://reviewboard.kde.org/r/1891/diff


Testing
-------

make test and sent mail.


Thanks,

Torgny

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/