[Kde-pim] Review Request: adds kmail support for RFC2369, List-* headers to display in preview pane with links to URLs

[Daniel Black]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1768/
-----------------------------------------------------------

(Updated 2009-10-05 14:29:35.921063)


Review request for KDE PIM.


Changes
-------

Torgny: I've left Enterprise in for the time being. easy enough to remove. Added API docs since there were none to start with.
Markus/David: Thanks for the visual ideas. What I have done is:
1. Reorder header fields in a logical order, Post, Archive, Help, Owner, Subscribe, Unsubscribe - unsubscribe left till last for easy viability.
2. mailto -> email, http/https -> web. Other protocols left as is (never seen anything else used and irc/ftp are probably friendly enough)
3. Header fields link to the mailto if one exists otherwise the first URL in the header field.
4. Multiple URLs - "Post (by web)" where Post is a mailto: link and web is a http one.
5. Many Multiple URLs - "Help (by web or irc or jabber or fish)" where Help talks the mailto: link and the others are their respective protocols.
6. As per Markus's suggestion I've gone for the two line approach.
7. Separations use an en-dash as Markus suggested.

Think I should make "Post (web or email)" when both options exist? The current display of "Post (by web)" slightly hides the email option.


Summary
-------

This patch displays the List{-ID,post,subscriber,unsubscribe,archive,help,owner} (<a href="http://tools.ietf.org/html/rfc2369">RFC2369</a> List-ID is RFC2919) URLs of email header fields on the view plane in kmail. The display occurs on styles: Enterprise, Fancy, Standard, and Long. The format is:
List: Linux Australia  Post Unsubscribe(http mailto) Subscribe(http mailto) Archive Help 
The Post, Archive and Help are links to the single URL present. The Subscribe/Unsubcribe have two links so the http and mailto, extracted from the URL protocol, are links to those two options. Only list tags that exist are show.
Visual separation from the title and Post.... is a bit weak. Is "List: List Title <Post....>" better?


Diffs (updated)
-----

  /trunk/KDE/kdepim/kmail/headerstrategy.cpp 1031501 
  /trunk/KDE/kdepim/kmail/headerstyle.cpp 1031501 
  /trunk/KDE/kdepim/kmail/mailinglist-magic.h 1031501 
  /trunk/KDE/kdepim/kmail/mailinglist-magic.cpp 1031501 

Diff: http://reviewboard.kde.org/r/1768/diff


Testing
-------

tested on kmail-1.12.1 (kde-4.3.1)


Screenshots (updated)
-----------

Enterprise Style
  http://reviewboard.kde.org/r/1768/s/224/
Fancy Style
  http://reviewboard.kde.org/r/1768/s/225/
Long Style
  http://reviewboard.kde.org/r/1768/s/226/


Thanks,

Daniel

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/