[Kde-pim] Review Request: Maemo fixes in Kcal

Alvaro Manera alvaro.manera at nokia.com
Thu Oct 15 07:56:18 BST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1489/
-----------------------------------------------------------

(Updated 2009-10-15 06:56:18.031463)


Review request for KDE PIM.


Changes
-------

Forgot to correct the "is" from David's comments. And I also removed the other ones in other functions.


Summary
-------

This is a combined patch of all the changes we have in our trunk, before the implementation of the RecurrenceID.

These changes include:
* Contacts in the incidence. (I don't know if you need this, as you have the addressbook) ¿?
* Some small fixes in our side (like copy constructor in listbase).
* Handling the updates. This fixes the bug that you end up having a duplicate entry in the Hash table when modifying an event. 


Diffs (updated)
-----

  trunk/KDE/kdepimlibs/kcal/alarm.cpp 1034333 
  trunk/KDE/kdepimlibs/kcal/calendarlocal.h 1034333 
  trunk/KDE/kdepimlibs/kcal/calendarlocal.cpp 1034333 
  trunk/KDE/kdepimlibs/kcal/calendarnull.h 1034333 
  trunk/KDE/kdepimlibs/kcal/calendarnull.cpp 1034333 
  trunk/KDE/kdepimlibs/kcal/event.cpp 1034333 
  trunk/KDE/kdepimlibs/kcal/incidence.cpp 1034333 
  trunk/KDE/kdepimlibs/kcal/incidencebase.h 1034333 
  trunk/KDE/kdepimlibs/kcal/incidencebase.cpp 1034333 
  trunk/KDE/kdepimlibs/kcal/journal.cpp 1034333 
  trunk/KDE/kdepimlibs/kcal/listbase.h 1034333 
  trunk/KDE/kdepimlibs/kcal/todo.cpp 1034333 

Diff: http://reviewboard.kde.org/r/1489/diff


Testing
-------


Thanks,

Alvaro

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


More information about the kde-pim mailing list