[Kde-pim] Review Request: knarticlefactory.cpp:205: warning: unused variable 'mbox'

[Guy Maurel]

> On 2009-11-19 18:09:50, Kevin Krammer wrote:
> > /trunk/KDE/kdepim/knode/knarticlefactory.cpp, line 206
> > <http://reviewboard.kde.org/r/2216/diff/1/?file=14700#file14700line206>
> >
> >     this looks strange. mbox is the loop's main variable, if it is not used there is something wrong with the loop.
> >     
> >     my guess is that it should be
> >     art->to()->addAdress(mbox);
> 
> Stephen Kelly wrote:
>     I agree with Kevin here.
>     
>     This change was introduced here: http://websvn.kde.org/trunk/KDE/kdepim/knode/knarticlefactory.cpp?r1=604655&r2=604654&pathrev=604655
>     
>     I think the intent is clear especially given the similar code elsewhere in the same file.

you are right.
If one have a look at lines 171 and 177 for the same code

see: knarticlefactory-gm-83-a.diff


- Guy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2216/#review3168
-----------------------------------------------------------


On 2009-11-19 17:58:27, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2216/
> -----------------------------------------------------------
> 
> (Updated 2009-11-19 17:58:27)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> The dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=
> reports:
> /.../kdepim/knode/knarticlefactory.cpp:205: warning: unused variable 'mbox'
> 
> at
> KNArticleFactory::createReply
> 
> my proposal: add Q_UNUSED( mbox)
> see: knarticlefactory-gm-83.diff
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/knode/knarticlefactory.cpp 1046400 
> 
> Diff: http://reviewboard.kde.org/r/2216/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/