[Kde-pim] Review Request: encryptemailcontroller.cpp:247: warning: unused parameter 'result'

[Stephen Kelly]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2239/#review3206
-----------------------------------------------------------


Instead, please use the result parameter.

See kdepim/kleopatra/crypto/task.h to see what is available, and other uses of the Result class to see how it should be used.

Probably check if there is an error at least.

- Stephen


On 2009-11-20 17:56:02, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2239/
> -----------------------------------------------------------
> 
> (Updated 2009-11-20 17:56:02)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> The dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=
> reports:
> /.../kdepim/kleopatra/crypto/encryptemailcontroller.cpp:247: warning: unused parameter 'result'
> 
> at
> EncryptEMailController::doTaskDone
> 
> my proposal: add Q_UNUSED( )
> see: encryptemailcontroller-gm-98.diff
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kleopatra/crypto/encryptemailcontroller.cpp 1047639 
> 
> Diff: http://reviewboard.kde.org/r/2239/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/