[Kde-pim] Review Request: assuanserverconnection.cpp:1340: warning: suggest explicit braces to avoid ambiguous 'else'

[Stephen Kelly]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2130/#review3008
-----------------------------------------------------------

Ship it!


Looks good. Please commit.

- Stephen


On 2009-11-10 18:02:45, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2130/
> -----------------------------------------------------------
> 
> (Updated 2009-11-10 18:02:45)
> 
> 
> Review request for KDE PIM.
> 
> 
> Summary
> -------
> 
> The dashboard
>   http://dashboard.akonadi-project.org/CDash/index.php?project=kdelibs
> reports:
> /.../kdepim/kleopatra/uiserver/assuanserverconnection.cpp:1340: warning: suggest explicit braces to avoid ambiguous 'else'
> /.../kdepim/kleopatra/uiserver/assuanserverconnection.cpp:616: warning: suggest explicit braces to avoid ambiguous 'else'
> 
> my proposal: complete with some more parentheses
> see: assuanserverconnection-gm-52.diff
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepim/kleopatra/uiserver/assuanserverconnection.cpp 1046400 
> 
> Diff: http://reviewboard.kde.org/r/2130/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>

_______________________________________________
KDE PIM mailing list kde-pim at kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/